[1.1] Add funding_cancelled message.
#349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZmnSCPxj
force-pushed
the
funding-cancelled
branch
from
4510221
to
d0d11eb
Compare
| @@ -306,4 +306,5 @@ offerer | |||
| offerer's | |||
| incentivize | |||
| redemptions | |||
| vbytes | |||
| cancelled | |||
| vbytes | |||
| @@ -19,6 +19,7 @@ These flags may only be used in the `init` message: | |||
| | 0/1 | `option-data-loss-protect` | Requires or supports extra `channel_reestablish` fields | [BOLT #2](02-peer-protocol.md#message-retransmission) | | |||
| | 3 | `initial_routing_sync` | Indicates that the sending node needs a complete routing information dump | [BOLT #7](07-routing-gossip.md#initial-sync) | | |||
| | 4/5 | `option_upfront_shutdown_script` | Commits to a shutdown scriptpubkey when opening | [BOLT #2](02-peer-protocol.md#the-open_channel-message) | | |||
| | 8/9 | `option-funding-cancelled` | Requires or supports `funding_cancelled` message | [BOLT #2](02-peer-protocol.md#the-funding_cancelled-message) | | |||
There was a problem hiding this comment.
Nit: Doesn't "require" imply "support" in this context? Would Supports funding_cancelled message be enough?
There was a problem hiding this comment.
Even bit requires the feature, odd bit supports if possible ("its ok to be odd").
There was a problem hiding this comment.
See also bits 0/1
There was a problem hiding this comment.
@ZmnSCPxj Ah, my bad! Missed the 8/9. Sorry! :-)
|
Closing: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposed new message indicates that the funding transaction can never confirm. For example, to implement replace-by-fee funding transactions, or to implement multi-channel funding transactions (see rationale of message for details).
This is inteded for BOLT 1.1