Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concretize Output Ordering to be less confusing #876

Merged
merged 2 commits into from Jun 21, 2021

Conversation

TheBlueMatt
Copy link
Collaborator

@TheBlueMatt TheBlueMatt commented May 24, 2021

This is based on #872 and takes rusty's suggestion of just using a list. I've found linking to BIP 69 (which is itself underspecified) confusing from the first time I read this.

Fixes #456.

Copy link
Collaborator

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase, otherwise LGTM 👍

@TheBlueMatt
Copy link
Collaborator Author

Rebased.

Copy link
Collaborator

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b68bf7c

@rustyrussell
Copy link
Collaborator

rustyrussell commented Jun 7, 2021

Ack b68bf7c

@ariard
Copy link
Contributor

ariard commented Jun 21, 2021

ACK b68bf7c

Copy link
Collaborator

@rustyrussell rustyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack 22d7494

Copy link
Collaborator

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 22d7494

@t-bast t-bast merged commit bda72c8 into lightning:master Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not reference the underspecified (and generally discouraged) BIP 69
4 participants