Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LND fails a payment on getting FeeInsufficient instead of retrying it with updated fees #2540

Closed
akumaigorodski opened this issue Jan 26, 2019 · 7 comments
Assignees
Labels
P1 MUST be fixed or reviewed v0.13
Milestone

Comments

@akumaigorodski
Copy link

akumaigorodski commented Jan 26, 2019

Details are outlined here: https://github.com/btcontract/lnwallet/issues/123

When getting a FeeInsufficient on sending a payment LND seems to fail it right away while I'd expect it to retry it with bumped fees.

@joostjager
Copy link
Collaborator

I suspect this will be fixed by #2151

@Roasbeef Roasbeef added this to the 0.10.0 milestone Jan 14, 2020
@Roasbeef Roasbeef added this to To do in v0.10.0-beta via automation Jan 17, 2020
@Roasbeef Roasbeef modified the milestones: 0.10.0, 0.11.0 Feb 26, 2020
@Roasbeef Roasbeef removed this from To do in v0.10.0-beta Feb 26, 2020
@cfromknecht cfromknecht added this to To do in v0.11.0-beta via automation Apr 21, 2020
@Roasbeef
Copy link
Member

Roasbeef commented May 5, 2020

Should fix this for 0.11.

@joostjager
Copy link
Collaborator

I think it is probably good to wait for the in-memory graph to land.

@cfromknecht
Copy link
Contributor

@Roasbeef @joostjager should we continue targeting this for 0.11?

@joostjager
Copy link
Collaborator

I still think that if we are going to overhaul the graph structure, it is overall cheaper to implement this afterwards.

@cfromknecht cfromknecht removed this from To do in v0.11.0-beta Jun 23, 2020
@cfromknecht cfromknecht removed this from the 0.11.0 milestone Jun 23, 2020
@cfromknecht cfromknecht added v0.12 and removed v0.11 labels Jun 23, 2020
@halseth
Copy link
Contributor

halseth commented Jul 20, 2020

The approach taken in #2151 is to just update the bandwidth hints with updated fees

@Roasbeef Roasbeef added this to the 0.12.0 milestone Jul 22, 2020
@Roasbeef Roasbeef added this to To do in v0.12.0-beta Jul 22, 2020
@Roasbeef Roasbeef removed this from To do in v0.12.0-beta Oct 1, 2020
@Roasbeef Roasbeef modified the milestones: 0.12.0, 0.13.0 Oct 1, 2020
@Roasbeef Roasbeef added the P1 MUST be fixed or reviewed label Jan 28, 2021
@Roasbeef Roasbeef added this to Blocked in v0.13.0-beta Jan 28, 2021
@halseth halseth added v0.13 and removed v0.12 labels Feb 25, 2021
@Roasbeef Roasbeef assigned yyforyongyu and unassigned bhandras Apr 2, 2021
@Roasbeef Roasbeef moved this from Blocked to In progress in v0.13.0-beta Apr 2, 2021
@Roasbeef Roasbeef moved this from In progress to Review in progress in v0.13.0-beta Apr 21, 2021
@Roasbeef Roasbeef moved this from Review in progress to Reviewer approved in v0.13.0-beta May 7, 2021
@Roasbeef Roasbeef moved this from Reviewer approved to Blocked in v0.13.0-beta May 11, 2021
@Roasbeef Roasbeef modified the milestones: 0.13.0, 0.13.1 Jun 17, 2021
@Roasbeef
Copy link
Member

Fixed by #5332

v0.13.0-beta automation moved this from Blocked to Done Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 MUST be fixed or reviewed v0.13
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

7 participants