rpc: Bake and validate macaroons with external permissions #5304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orbitalturtle
force-pushed
the
check-macaroon-rpcs
branch
2 times, most recently
from
4c463a1
to
8a05ff5
Compare
orbitalturtle
force-pushed
the
check-macaroon-rpcs
branch
3 times, most recently
from
7cedca4
to
56651aa
Compare
guggero
reviewed
May 18, 2021
There was a problem hiding this comment.
Great feature, thanks a lot for the PR!
Also nice commit structure, was very easy to review.
Did a high-level pass and left some comments. Just a heads up: As we're currently in the RC phase for v0.13.0-beta this won't make it into that version and further reviews might be somewhat delayed. Hope to get this in soon in the v0.14.0 cycle though!
guggero
added
enhancement
orbitalturtle
force-pushed
the
check-macaroon-rpcs
branch
from
56651aa
to
9a4144a
Compare
orbitalturtle
force-pushed
the
check-macaroon-rpcs
branch
3 times, most recently
from
b7fc717
to
51dacf5
Compare
guggero
approved these changes
Jul 9, 2021
ellemouton
approved these changes
Jul 13, 2021
orbitalturtle
force-pushed
the
check-macaroon-rpcs
branch
3 times, most recently
from
35fb878
to
35eb7ea
Compare
orbitalturtle
force-pushed
the
check-macaroon-rpcs
branch
3 times, most recently
from
5ca63da
to
cae0a34
Compare
|
Just needs an addition to the release notes now for 0.14! |
orbitalturtle
added a commit
to orbitalturtle/lnd
that referenced
this pull request
Aug 1, 2021
orbitalturtle
force-pushed
the
check-macaroon-rpcs
branch
from
cae0a34
to
f07e57c
Compare
|
Great, rebased that and added some release notes @Roasbeef ! Also thank you for the reviews @guggero and @ellemouton ! |
guggero
reviewed
Aug 2, 2021
orbitalturtle
force-pushed
the
check-macaroon-rpcs
branch
from
f07e57c
to
449f84d
Compare
|
Visit https://dashboard.github.orijtech.com?back=0&pr=5304&remote=true&repo=orbitalturtle%2Flnd to see benchmark details. |
|
Sorry for taking so long - made those changes @guggero |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following step two of these directions for stateless-remote mode (lightninglabs/lightning-terminal#160), this PR:
Use case: With the new BakeMacaroon option, users of lightning terminal can bake a "super" macaroon permitting a user to use LND calls, as well as calls to the daemons Loop, Pool, and Faraday. The daemons incorporated into lightning terminal can use CheckMacaroonPermissions to validate the macaroon