Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi: update PSBT handling code to support new taproot-specific fields #6268

Closed
Roasbeef opened this issue Feb 15, 2022 · 0 comments · Fixed by #6450
Closed

multi: update PSBT handling code to support new taproot-specific fields #6268

Roasbeef opened this issue Feb 15, 2022 · 0 comments · Fixed by #6450
Assignees
@guggero
Labels
P2 should be fixed if one has time taproot
Projects
v0.15.0-beta
Milestone
v0.15.0

Comments

@Roasbeef
Copy link
Member

When using PSBT to sign taproot outputs, extra data needs to be communicated in the form of the control block, input values+scripts, and also which sighash type/extension to use. These new fields are defined in BIP 371. To support more generalized taproot tools/applications built on top of lnd, we should extend our PSBT handling an validation to understand, populate, and validate these fields.

Note that much of this work will actually be in btcwallet and btcd/btcutil/psbt, but we're tracking it here for cross-repo compatibility.

Related to #6267.
@Roasbeef Roasbeef added P2 should be fixed if one has time taproot labels Feb 15, 2022
@Roasbeef Roasbeef added this to the v0.15.0 milestone Feb 15, 2022
@Roasbeef Roasbeef added this to To do in v0.15.0-beta via automation Feb 15, 2022
@Roasbeef Roasbeef moved this from To do to In progress in v0.15.0-beta Apr 13, 2022
@guggero guggero self-assigned this Apr 14, 2022
@guggero guggero mentioned this issue Apr 14, 2022
Merged
@Roasbeef Roasbeef mentioned this issue Apr 22, 2022
Closed
@guggero guggero mentioned this issue Apr 23, 2022
Merged
@guggero guggero moved this from In progress to Review in progress in v0.15.0-beta May 3, 2022
@Roasbeef Roasbeef moved this from Review in progress to Reviewer approved + active testing in v0.15.0-beta May 11, 2022
v0.15.0-beta automation moved this from Reviewer approved + active testing to Done May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guggero guggero

Labels
P2 should be fixed if one has time taproot
Projects
No open projects
v0.15.0-beta
Done
Milestone
v0.15.0
Development

Successfully merging a pull request may close this issue.

taproot: add PSBT signing support for Taproot, fix remote signing Taproot support guggero/lnd
2 participants
@Roasbeef @guggero