Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOCC variable should be employed in makefiles #6489

Open
paboum opened this issue May 1, 2022 · 2 comments · May be fixed by #8900
Open

GOCC variable should be employed in makefiles #6489

paboum opened this issue May 1, 2022 · 2 comments · May be fixed by #8900
Labels
feature request Requests for new features golang/build system Related to the go language and compiler

Comments

@paboum
Copy link

paboum commented May 1, 2022

I compile lnd on raspberry pi which by default has no go>=1.17.

I installed go.1.18.1 with
go get golang.org/dl/go1.18.1
go1.18.1 download

But now my go binary is go1.18.1, not go. So the lnd makefiles fail.

I had to work around with: sed -i "s/go /go1.18.1 /g" Makefile

But I would much more prefer to do: GOCC=go1.18.1 make install, just as in ipfs makefiles.

@guggero
Copy link
Collaborator

guggero commented May 2, 2022

I'm willing to review a PR to add this. But how about just doing alias go=go1.18.1 to fix this across many other projects that likely don't support this?

@paboum
Copy link
Author

paboum commented May 3, 2022

But how about just doing alias go=go1.18.1 to fix this across many other projects that likely don't support this?

That would be a python way of resolving things, and go only inherits after C, Alef and Oberon-2 (which in turn inherits after Modula-2).

Please also note the builtin gnu make rule set, it may follow the tradition and introduce $(GOC) (not $(GOCC) however):
https://www.gnu.org/software/make/manual/make.html#Catalogue-of-Rules

@Roasbeef Roasbeef added golang/build system Related to the go language and compiler feature request Requests for new features labels May 3, 2022
@guggero guggero linked a pull request Jul 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new features golang/build system Related to the go language and compiler
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants