multi: configurable remote chan reserve #6956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
force-pushed
the
configureChanReserve
branch
2 times, most recently
from
5831b99
to
ccf0dbc
Compare
ellemouton
force-pushed
the
configureChanReserve
branch
from
ccf0dbc
to
85879e6
Compare
ellemouton
commented
Sep 30, 2022
|
@sputn1ck: review reminder |
sputn1ck
reviewed
Oct 7, 2022
There was a problem hiding this comment.
Tested the changes, when using a lower than accepted remote reserve sats, my funds where locked until I restarted lnd. Is that expected? The other peer is using the tagged release 0.15.1-beta
./lncli-debug -n regtest listunspent
{
"utxos": [
{
"address_type": 4,
"address": "bcrt1p7r5fzhfvaa03zghds7cedkzw3zzssr9ctvy6mcjcrpkkm74fkj6sfdvf2x",
"amount_sat": 1000000,
"pk_script": "5120f0e8915d2cef5f1122ed87b196d84e8885080cb85b09ade258186d6dfaa9b4b5",
"outpoint": "3264a46325894726614c097f1cd6300b1f388a95c9e5849c4a4559026d17112b:0",
"confirmations": 3
}
]
}
./lncli-debug -n regtest openchannel --remote_reserve_sats=100 02d0830a548c670525ae0f17c8c2f2d9a3f0c520da0cc75591394198092e46ce1a 50000
[lncli] rpc error: code = Unknown desc = channel reserve of 100 sat is too small, min is 354 sat
./lncli-debug -n regtest listunspent
{
"utxos": []
}
2a76a68
to
0c0d3de
Compare
|
ahhhh you are completely right @sputn1ck! Thanks for catching this. Have updated it so that the |
sputn1ck
requested changes
Oct 7, 2022
sputn1ck
reviewed
Oct 7, 2022
In this commit, the sanity checks in the CommitConstraints method is moved out into a helper function called VerifyConstraints. This is done so that the sanity checks can be performed more easily else where in the code base. The new helper method is then called in the handleInitFundingMsg method of the funding manager before the OpenChannelMessage is sent.
In this commit, the channel reserve of an initiated channel is made to be optionally configurable.
ellemouton
force-pushed
the
configureChanReserve
branch
from
0c0d3de
to
eeed3e6
Compare
sputn1ck
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the remote channel reserve amount is made to be configurable.
Up until now, it has always just been 1% of the channel capacity.
This is just an updated of this pr. The original author has been preserved as
commit author where it applies.
Fixes #1083
Related #800