Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md claims segwit support has not been merged into master #740

Closed
ysangkok opened this issue Feb 7, 2018 · 4 comments
Closed

README.md claims segwit support has not been merged into master #740

ysangkok opened this issue Feb 7, 2018 · 4 comments
Labels
documentation Documentation changes that do not affect code behaviour

Comments

@ysangkok
Copy link

ysangkok commented Feb 7, 2018

But it has, see btcsuite/btcd#656
@snavsenv
Copy link

snavsenv commented Feb 7, 2018

sounds like you should make a pull request

@ysangkok
Copy link
Author

ysangkok commented Feb 7, 2018

But there is still a reason to use roasbeef's btcd, I don't know what it is, exactly. So I can't write a PR.

@halseth
Copy link
Contributor

halseth commented Feb 7, 2018

You are right that the README is wrong on that point. Reason the roasbeef fork is still needed is because it has neutrino related additions, that's not merged to master.

@halseth halseth added the documentation Documentation changes that do not affect code behaviour label Feb 7, 2018
@hackerrdave hackerrdave mentioned this issue Feb 11, 2018
Merged
@Roasbeef
Copy link
Member

Fixed by #754.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Documentation changes that do not affect code behaviour
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ysangkok @Roasbeef @halseth @snavsenv