Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: create mission control profiles for payment/pathfinding related calls #7812

Open
Roasbeef opened this issue Jul 7, 2023 · 0 comments
Labels
enhancement Improvements to existing features / behaviour intermediate Issues suitable for developers moderately familiar with the codebase and LN routing rpc Related to the RPC interface

Comments

@Roasbeef
Copy link
Member

Roasbeef commented Jul 7, 2023

Is your feature request related to a problem? Please describe.

Today we have two path finding algos, and a number of diff params for each aglo. If a user wants to experiment with all the new knobs they're able to dynamically modify the current params using the SetMissionControlConfig call. However this applies the config globally. This restricts certain cases of multi-user systems, and has a sort of race conditio nbuilt in as concurrent payment attempts by use diff configs.

Describe the solution you'd like

We should create a way to allow namespaced routing configs. Maybe one config is for smaller, more quickly resolving payments. Maybe another is for larger payments, that cares less about fees and the time of completion, etc.

Profiles should be able to be created and named using the routerrpc gRPC server. Any payment related calls should also optionally take a profile, to be used when carrying out path finding. We can assume that SetMissionControlConfig continues to modify the current "default" profile.

This functionality is very useful, as it can be used to perform A/B tests for a payment related service, without "polluting" other payment attempts or path finding calls.

Profiles should be kept on disk to ensure durability between restarts.

@Roasbeef Roasbeef added enhancement Improvements to existing features / behaviour rpc Related to the RPC interface intermediate Issues suitable for developers moderately familiar with the codebase and LN routing labels Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features / behaviour intermediate Issues suitable for developers moderately familiar with the codebase and LN routing rpc Related to the RPC interface
Projects
None yet
Development

No branches or pull requests

1 participant