Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document various enums and flags #31

Closed
Mr0grog opened this issue Aug 9, 2016 · 0 comments
Closed

Document various enums and flags #31

Mr0grog opened this issue Aug 9, 2016 · 0 comments

Comments

@Mr0grog
Copy link

Mr0grog commented Aug 9, 2016

In writing code for setting account flags, it would be nice to be able to use the relevant enum:

import static org.stellar.sdk.xdr.AccountFlags.*;
new SetOptionsOperation.Builder()
    .setSetFlags(AUTH_REQUIRED_FLAG.getValue() | AUTH_REVOCABLE_FLAG.getValue())
    .build();

// the above is more clear than:
new SetOptionsOperation.Builder()
    .setSetFlags(1 | 2)
    .build();

…but the XDR bits are not documented, so someone wouldn't know those exist without browsing the source. It would be nice if these were documented somehow (not sure how easy that is since the XDR is generated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant