Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more standardized menu for dropdown #31

Open
inooid opened this issue Oct 21, 2019 · 1 comment
Open

Add more standardized menu for dropdown #31

inooid opened this issue Oct 21, 2019 · 1 comment

Comments

@inooid
Copy link
Contributor

inooid commented Oct 21, 2019

Description

Currently the dropdown components (and sub components) make it possible to render anything within the "popped out" box, but this gives us consumers a lot of freedom. I would like to see some more guidance in how to render these dropdown lists.

How about a DropdownList or DropdownMenu component that is just a styled ul and li list?

Requirements

  • Don't narrow down the API of the dropdown component itself, people should still be allowed to render things above or below the list.
  • Standardise the way we create context menus

Design/Examples

Currently within the Lightspeed products, we've seen some context menus being used within the sidebar:

image

But also in our some other places:

image

Both of these designs already show and proof that the implementations are going all over the place, while they're pretty similar.

@tombertrand
Copy link

tombertrand commented Oct 22, 2019

Can only think of these 2 for now, perhaps scope creep and remove that dotted like when a button is focused :creeper:

Vendor Return

image

Filters on RR

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants