Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage spritemaps for Flags #57

Open
xdrdak opened this issue Dec 5, 2019 · 0 comments
Open

Leverage spritemaps for Flags #57

xdrdak opened this issue Dec 5, 2019 · 0 comments

Comments

@xdrdak
Copy link
Contributor

xdrdak commented Dec 5, 2019

Currently, Flags has the same implementation/behaviour as Icon, in which loading the base component <Flag> will cause all svgs to be loaded as a chunk. This is normal behaviour, however it's somewhat problematic in this use case since when we're using flags, we usually want all of them loaded at the same time.

What we should be doing is instead of loading all SVGs for Flags, would be to leverage an svg spritemap instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant