Add snowflake support #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the report. I understand that you want to add snowflake support to sqls, and I'm very grateful that you made a pull request for it. There are a number of reasons for this, but the main problem is that it can be difficult to maintain. Especially with products like Snowflake, BigQuery and Athena, for which I can't easily set up a test environment, I can't make sure that the code is correct. This is critical for me to maintain. |
|
yeah that makes sense. i think you can sign up for a trial snowflake account but dont think its ideal. I think I can try to maintain this on the fork unless if you have other ideas. thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! thanks for starting this project. its really neat. I have attempted to add snowflake support and wondering if you are accepting any pull requests. I am new to Golang and tried to follow your code as much as possible. Let me know if something are not upto the standards. I will also add tests and to readme if you are fine adding this to the repo.
Thanks