Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sensitive information leakage #316

Closed
alpha0490 opened this issue Jan 2, 2021 · 2 comments
Closed

Sensitive information leakage #316

alpha0490 opened this issue Jan 2, 2021 · 2 comments

Comments

@alpha0490
Copy link

alpha0490 commented Jan 2, 2021 •
edited

your api keys are leaked here

https://github.com/ligi/PassAndroid/blob/6cdd7ce4f74be54a538014014c426bc647d550b1/android/src/withMaps/AndroidManifest.xml
@ligi
Copy link
Owner

ligi commented Feb 16, 2021

Wondering what exactly is sensitive about the maps API key. What harm can people do having it?

@ligi
Copy link
Owner

ligi commented Apr 10, 2023

I really do not see the point - it needs to be available on the edge - so even if I obfuscate it there - it is in the end deliverable - so no real point in hiding it IMHO.

@ligi ligi closed this as completed Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ligi @alpha0490