Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to scala 2.13.0-RC1 #220

Merged
merged 2 commits into from Apr 26, 2019
Merged

Switch to scala 2.13.0-RC1 #220

merged 2 commits into from Apr 26, 2019

Conversation

alexarchambault
Copy link
Contributor

No description provided.

olafurpg
olafurpg approved these changes Apr 26, 2019
View reviewed changes
Copy link
Collaborator

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 This unblocks a lot of downstream libraries like scalapb, coursier and scalameta. It would be good to avoid the custom zinc worker sooner rather than later however, is that tracked in an issue somewhere?

@olafurpg olafurpg merged commit 3af39b6 into com-lihaoyi:master Apr 26, 2019
@alexarchambault alexarchambault deleted the scala-2.13.0-RC1 branch April 26, 2019 09:51
@alexarchambault
Copy link
Contributor Author

com-lihaoyi/mill#593 may fix that

@olafurpg olafurpg mentioned this pull request Apr 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olafurpg olafurpg olafurpg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexarchambault @olafurpg