Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to resolve by stream? #592

Closed
garak opened this issue Apr 14, 2015 · 12 comments
Closed

How to resolve by stream? #592

garak opened this issue Apr 14, 2015 · 12 comments
Labels
Level: New Feature 🆕 This item involves the introduction of new functionality. State: Need To Investigate 🔎 This item requires additional investigation to determine a resolution.

Comments

@garak
Copy link
Contributor

garak commented Apr 14, 2015

I'm using LiipImagineBundle with Gaufrette.
Gaufrette is configured to use aws S3, so I configured a StreamLoader. So far so good.
Now the problem is that I'm not able to resolve thumbnails via Gaufrette, since the only way I found here is AwsS3Resolver, that is not what I want: AwsS3Resolver bypasses Gaufrette and so I cannot use Gaufrette options (most notably the "directory" options), but the worst point is that this completely defeats the Gaufrette abstraction layer (e.g. I cannot easily switch between filesystem abstractions).
So, is a stream resolver really missing here, or am I doing something wrong?
Thanks in advance.

@makasim
Copy link
Collaborator

makasim commented Apr 14, 2015

We can introduce a gaufrette resolver. Sounds reasonable to me.

@romaricdrigon
Copy link

+1 for a Gaufrette resolver.
Using stream feels like a step back from the Symfony2 style.

@makasim
Copy link
Collaborator

makasim commented May 7, 2015

any takers on this?

@garak
Copy link
Contributor Author

garak commented May 7, 2015

I tried to write something myself, and I ended up with some code. But my main issue is how to get the asbtraction work with every implementation. So, I implemented my GaufreffeResolver, but in the resolve method I have to call $this->filesystem->getAdapter()->getUrl(), but unfortunately getUrl() is not present in every adapter. I'm stuck at this point.

@makasim
Copy link
Collaborator

makasim commented May 7, 2015

I see, it is hard to use gaufrette as a resolver. but can at least use it as a data loader, would it be useful?

@makasim makasim closed this as completed Jun 16, 2015
@romaricdrigon
Copy link

Why closing it, something was done?

@makasim
Copy link
Collaborator

makasim commented Jun 16, 2015

The interface of a resolver is richer than stream can provide us with. So nothing to do here. The stream data loader is already here.

@makasim makasim reopened this Jun 16, 2015
@makasim makasim closed this as completed Jun 16, 2015
@romaricdrigon
Copy link

I think the issue is about working with Gaufrette by stream, and not by using objects provided by Gaufrette.
At least it is what I understood from the first post. And I can hardly see a stream having a better interface than a Gaufrette filesystem object.

@makasim
Copy link
Collaborator

makasim commented Jun 16, 2015

The PR is very welcome, I dont see much sense keeping it open, since it is just an addition which is not block us in any way.

@makasim
Copy link
Collaborator

makasim commented Jun 16, 2015

The PR is very welcome (:

@romaricdrigon
Copy link

Well, if someone wants to have some time on it, the issue keeps track of it. For instance for some Symfony hack day.

@makasim makasim added the Level: New Feature 🆕 This item involves the introduction of new functionality. label Jun 16, 2015
@makasim makasim reopened this Jun 16, 2015
@michellesanver michellesanver added the State: Need To Investigate 🔎 This item requires additional investigation to determine a resolution. label Oct 4, 2019
@michellesanver
Copy link
Contributor

This needs an issue with a more clear description of the feature and the requested implementation. Create a new issue with clarifications, link this one, and close when done :)

@dbu dbu closed this as completed Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Level: New Feature 🆕 This item involves the introduction of new functionality. State: Need To Investigate 🔎 This item requires additional investigation to determine a resolution.
Projects
None yet
Development

No branches or pull requests

5 participants