Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractDatabaseTool::getBackupService() relies on deprecated method #184

Closed
mbabker opened this issue May 2, 2022 · 1 comment · Fixed by #255
Closed

AbstractDatabaseTool::getBackupService() relies on deprecated method #184

mbabker opened this issue May 2, 2022 · 1 comment · Fixed by #255
Labels
enhancement New feature or request

Comments

@mbabker
Copy link
Contributor

mbabker commented May 2, 2022

The AbstractDatabaseTool::getBackupService() method tries to build a backup service by identifying the database platform when the ORM is in use. However, Doctrine\DBAL\Platforms\AbstractPlatform::getName() is deprecated in favor of identifying platforms based on their class names and instanceof checks.

This one isn't a straightforward replacement because the container parameter name that this code is trying to reference is built around the simple identifiers the getName() method was returning, so a new strategy for resolving the database backup service for the ORM is going to be needed (for simplicity sake, you can probably map instanceof checks to the names that the deprecated getName() method is using).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants