Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the Twig filter #9

Closed
stof opened this issue Oct 12, 2011 · 6 comments
Closed

Rename the Twig filter #9

stof opened this issue Oct 12, 2011 · 6 comments

Comments

@stof
Copy link
Contributor

stof commented Oct 12, 2011

Using the same name than AvalancheImagineBundle means that both bundles are exclusive.
@LouTerrailloune
Copy link
Contributor

Sure, but who is going to use the 2 bundles in the same application ?

@stof
Copy link
Contributor Author

stof commented Oct 12, 2011

well, maybe nobody, but we should not make it broken by design. This is also the reason why both bundles use different namespaces.

@LouTerrailloune LouTerrailloune mentioned this issue Oct 13, 2011
Merged
@lsmith77
Copy link
Contributor

I agree that we shouldn't change the name just to enable coexistence .. but it seems that the case is being made in #11 that we should rename for other reasons anyway ..

@stof
Copy link
Contributor Author

stof commented Oct 14, 2011

btw, the new name should make clear that it is related to imagine IMO. apply_filter is pretty bad about explicitness

@lsmith77
Copy link
Contributor

good point.

@ghost
Copy link

ghost commented Oct 19, 2011

Fixed in b00818e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lsmith77 @stof @LouTerrailloune