Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal system #356

Closed
lijim opened this issue May 11, 2022 · 1 comment
Closed

Modal system #356

lijim opened this issue May 11, 2022 · 1 comment
Milestone
Core Game Engine ...

Comments

@lijim
Copy link
Owner

lijim commented May 11, 2022

We need a modal system to display:

This ticket will encompass the creation of a modal system to display those things

  • use React.Portal to create the modal on a separate layer
  • lazy load the modals
  • make the modals actionable in redux, e.g. closeModal, openModal(ModalTypes.INSTRUCTIONS)
@lijim
Copy link
Owner Author

lijim commented May 25, 2022

Not doing for now - making it page based for these. May be better for SEO too in the future if we stop redirecting for certain pages back to the homescreen (e.g. have the rules page show up in Google)

@lijim lijim closed this as completed May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Core Game Engine - Operation fun
Development

No branches or pull requests
1 participant
@lijim