Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hooks should handle dynamic deps array for custom hooks #12

Closed
lilactown opened this issue Jan 31, 2020 · 1 comment
Closed

Hooks should handle dynamic deps array for custom hooks #12

lilactown opened this issue Jan 31, 2020 · 1 comment

Comments

@lilactown
Copy link
Owner 

(defn use-custom [deps f]
  (use-effect
    deps
    (f)))

At the moment, deps will be silently ignored and this use-effect macro will emit nothing.

Should fall back to runtime detection of :once / :always / a vector.
@lilactown
Copy link
Owner Author

Closed d72f922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lilactown