Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding configured incorrectly #6

Closed
ssatia opened this issue Dec 8, 2017 · 1 comment
Closed

Embedding configured incorrectly #6

ssatia opened this issue Dec 8, 2017 · 1 comment

Comments

@ssatia
Copy link

ssatia commented Dec 8, 2017

self. inputs_with_embed holds the embeddings concatenated with self.inputs. However, the embeddings are not being used since the RRN is still using self.inputs:

val, state_ = tf.nn.dynamic_rnn(cell, self.inputs, dtype=tf.float32, scope="dynamic_rnn")

@lilianweng
Copy link
Owner

You are totally right. The issue has been fixed in commit 084707d :)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants