Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test all Kubernetes components work #9

Closed
lilic opened this issue Jul 2, 2018 · 4 comments
Closed

Test all Kubernetes components work #9

lilic opened this issue Jul 2, 2018 · 4 comments

Comments

@lilic
Copy link
Owner

lilic commented Jul 2, 2018

To avoid #8 (review) in the future there should also be a few test scenarios besides just deployment creation.

@lilic
Copy link
Owner Author

lilic commented Jul 2, 2018

@xmudrii I was thinking of something along these lines for the DNS check.

https://github.com/coreos/prometheus-operator/blob/cad1cb29a35b964258367090a837363be73afbdb/scripts/create-minikube.sh#L39-L40

If you can think of any other tests, feel free to add them, thanks!

@xmudrii
Copy link
Collaborator

xmudrii commented Jul 2, 2018

@lilic This one sounds great.

Beside that, I was thinking of adding one check to make sure the created deployment is ready (could also be done with JSONPath), so we're sure scheduler actually works (considering node is ready, that shouldn't be a problem, but one more check is not a bad idea).

/healthz check is what I'm trying to add as well. I got a comment on my PR that I should add it to E2E tests, so if I get it working, we could add it too.

I'll try to think about some other cases/components to test too. I'll probably PR something later in the evening or tomorrow.

@lilic
Copy link
Owner Author

lilic commented Jul 2, 2018

@xmudrii Sounds great, no hurry! Thanks again!

@lilic
Copy link
Owner Author

lilic commented Jul 4, 2018

Closed by #10

@lilic lilic closed this as completed Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants