Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player data not working #35

Closed
ghost opened this issue May 13, 2016 · 16 comments
Closed

Player data not working #35

ghost opened this issue May 13, 2016 · 16 comments

Comments

@ghost
Copy link

ghost commented May 13, 2016

I've updated to Minecraft 1.9.4 and it seems that everytime a player goes to Hub or disconnects, the players inventory resets, removing everything they had and treating the player like a new player by not saving the players data file. Been using proxy version #148 and bukkit-connect #98.

@ghost
Copy link
Author

ghost commented May 13, 2016

This is more than likely a server end issue being that LilyPad does not affect player/uuid files

@coelho
Copy link
Member

coelho commented May 13, 2016

Yeah this would be more of a Bukkit-Connect bug but this place is fine as well. I haven't heard of this bug before, I'll need to test it.

@ghost
Copy link
Author

ghost commented May 13, 2016

I'm sorry, I wasn't sure what it would fall under so I posted it here. Lilypad servers were the only ones experiencing this issue even on servers with no other plugins. I'll try to give more info if needed.

@ghost
Copy link
Author

ghost commented May 13, 2016

Posting a log of your console after player join/leave might help coelho

@ghost
Copy link
Author

ghost commented May 13, 2016

Okie dokie, will try that right away. The whole text file log or should I upload it to a site. I don't recall the name of the site at the moment for that though

@ghost
Copy link
Author

ghost commented May 13, 2016

Upload it to a site - it will make it easier for people to read

@ghost
Copy link
Author

ghost commented May 13, 2016

http://pastebin.com/gUxnGUUB
Link to the Hub server console log.
Did you want the logs for the proxy and connect as well?

@ghost
Copy link
Author

ghost commented May 16, 2016

If anything else is needed just let me know. I've been triple checking everything to try and verify if it's something wrong on my end but sadly have come up with nothing. I did use the previous version of bukkit connect #97 and it did solve the issue of players inventories being reset but then players skins weren't working or the permissions. So I'm guessing it is something with the bukkit-connect file after all. Also thanks again for looking it into the problem, I greatly appreciate it.

@manuelgu
Copy link
Contributor

manuelgu commented Jun 5, 2016

I can confirm this bug. Fresh install of spigot 1.9.4 and BukkitConnect.

@manuelgu
Copy link
Contributor

manuelgu commented Jun 8, 2016

This seems to be an issue with the playerdata files. OfflinePlayer#hasPlayedBefore returns false after the upgrade when the join for the first time.

@coelho Any clue?

@manuelgu
Copy link
Contributor

manuelgu commented Jun 8, 2016

After further investigation it turns out that the playerdata/uuid.dat files itself are stored properly.

  1. Move to somewhere else, put item in your inventory and log off.
  2. Inspect .dat file and see that location and inventory is stored
  3. Login again
  4. Inspect .dat file again, location and inventory is still stored
  5. Log off
  6. Inspect .dat file once more, see empty inventory and default location

@coelho
Copy link
Member

coelho commented Jun 8, 2016

I'll review this more in a few days. I think I have an idea of what it is.

@fatboy2380
Copy link

fatboy2380 commented Jun 11, 2016

I think I've been experiencing a similar if not the same issue where when I log in for the first time (new uuid.dat file) I spawn correctly, but when I log out, it will always spawn me back at that position when I log in even if I move.

From what I can tell it's creating 2 uuid.dat files, one with the offline uuid, and a new one is created with the correct uuid and is updated on logout, but it always reads from the offline uuid.dat file.

@Maescool
Copy link
Contributor

So I've been looking into the code
1.8 UserCache
public UserCache(MinecraftServer minecraftserver, File file) {
1.9 and up:
public UserCache(GameProfileRepository gameprofilerepository, File file) {

So, my guess is Bukkit-Connect, LoginListener, usercache part needs to be updated

@coelho
Copy link
Member

coelho commented Jun 13, 2016

Please check if the latest LilyPad-Connect fixes this?

@manuelgu
Copy link
Contributor

manuelgu commented Dec 3, 2016

This has been fixed and can be closed.

@coelho coelho closed this as completed Dec 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants