Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register burnables properly on fabric #81

Open
wants to merge 1 commit into
base: 1.19
Choose a base branch
from

Conversation

artemisSystem
Copy link

Fix #76

This also creates a <wood_item>s_that_burn tag for each wood item and use that for registration, so that warped and crimson ones don't burn (like all their wooden items in vanilla)

Fix lilypuree#76

This also creates a <wood_item>s_that_burn tag for each wood item and use that for registration, so that warped and crimson ones don't burn (like all their wooden items in vanilla)
@artemisSystem
Copy link
Author

@lilypuree do you have some time to look over this PR please? It fixes the quilt incompatibility

@Parkanizor
Copy link

Implementing this quick fix would be much appreciated. I'd build the fixed version myself but am dumb with computers and have a step fail every time :(

@Fuzzhamster5
Copy link

@lilypuree please could you do this as my quilt modpack REALLY needs this mod

@TimDev9492
Copy link

Bump

@Jothbot
Copy link

Jothbot commented May 2, 2023

bump

TheWinABagel added a commit to TheWinABagel/Decorative-Blocks that referenced this pull request Jul 22, 2023
@Fuzss
Copy link

Fuzss commented Jul 23, 2023

@artemisSystem Your implementation does not work, you cannot use tags. Fuel registration happens during mod setup, while tags are initialized from the current data pack during world loading. During mod setup tags are always empty, so you are essentially registering nothing to the fuel registry.

@artemisSystem
Copy link
Author

are you sure? did you test it? it's been a while but i think i remember it working perfectly. i'm assuming what's happening is it's registering the tag itself, and it's looked up in-world when needed

@Fuzss
Copy link

Fuzss commented Jul 23, 2023

Nvm, it seems like Fabric Api handles that case by clearing caches every time tags are loaded.
I just noticed that when trying TheWinABagel's fork (assuming they didn't make an error in adapting your PR) that only beams do work as fuel, palisades, seats and supports don't. Not sure what's the cause then and if your PR is affected, too.

@unilock
Copy link

unilock commented Jul 26, 2023

@Fuzss Looks like TheWinABagel's fork only adds the relevant block tags, not item tags. (TheWinABagel@e13290b#diff-f1afe8d18a5d2cf47951c181edce2c948583348d3ec780f1841fc9d8b1111af3)
(@TheWinABagel)

@TheWinABagel
Copy link

Whoops, will fix and upload a new version. I really need to figure out git one of these days...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants