Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Go 1.22 #2133

Closed
Tracked by #157782
stefanb opened this issue Jan 14, 2024 · 1 comment · Fixed by #2137
Closed
Tracked by #157782

Support Go 1.22 #2133

stefanb opened this issue Jan 14, 2024 · 1 comment · Fixed by #2137
Milestone

Comments

@stefanb
Copy link

stefanb commented Jan 14, 2024

Description

Trying to build with Go 1.22 (scheduled for February, currently rc1) fails with error:

# gvisor.dev/gvisor/pkg/sync
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20230715022000-fd277b20b8db/pkg/sync/gate_unsafe.go:114:3: undefined: goready
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20230715022000-fd277b20b8db/pkg/sync/gate_unsafe.go:144:2: undefined: gopark
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20230715022000-fd277b20b8db/pkg/sync/rwmutex_unsafe.go:76:3: undefined: semacquire
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20230715022000-fd277b20b8db/pkg/sync/rwmutex_unsafe.go:102:4: undefined: semrelease
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20230715022000-fd277b20b8db/pkg/sync/rwmutex_unsafe.go:152:3: undefined: semacquire
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20230715022000-fd277b20b8db/pkg/sync/rwmutex_unsafe.go:179:3: undefined: semrelease
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20230715022000-fd277b20b8db/pkg/sync/rwmutex_unsafe.go:207:3: undefined: semrelease
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20230715022000-fd277b20b8db/pkg/sync/seqcount.go:87:6: undefined: canSpin
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20230715022000-fd277b20b8db/pkg/sync/seqcount.go:89:4: undefined: doSpin

Found when testing Homebrew/homebrew-core#157782

The fix is likely updating the gvisor.dev/gvisor module, similar as it was done in superfly/flyctl#3161

@AkihiroSuda
Copy link
Member

Depends on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants