Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable critical logging before panics #38

Closed
failfmi opened this issue Feb 13, 2023 · 0 comments · Fixed by #44
Closed

Enable critical logging before panics #38

failfmi opened this issue Feb 13, 2023 · 0 comments · Fixed by #44
Assignees
Labels
enhancement New feature or request

Comments

@failfmi
Copy link
Collaborator

failfmi commented Feb 13, 2023

Currently, whenever the runtime panics with an actual written error (e.g. parent hash should be valid), there is only error returned, without actual critical logging:

running runtime function: Failed to call the runtime function exported function

The following log must appear:

CRITICAL target=runtime message=panicked at 'parent hash should be valid', -build error line- ext_logging_log_version_1 pkg=runtime module=go-wasmer

and afterwards

running runtime function: Failed to call the runtime function exported function.

@failfmi failfmi added the enhancement New feature or request label Feb 13, 2023
@failfmi failfmi changed the title enable critical logging before panics Enable critical logging before panics Feb 13, 2023
@radkomih radkomih mentioned this issue Feb 15, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants