sublime packages tests

limetext · Mar 17, 2016 · e765494 · e765494
1 parent 7cd20ad
commit e765494
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 10 deletions.
diff --git a/lib/packages/simple.go b/lib/packages/simple.go
@@ -18,6 +18,8 @@ type simple struct {
 	marshal  json.Unmarshaler
 }
 
+// TODO: better errors, maybe we should introduce error type and let
+// the loader decide how to log
 func (s *simple) Load() {
 	log.Debug("Loading %s", s.Name())
 	data, err := ioutil.ReadFile(s.filename)

diff --git a/lib/sublime/package_test.go b/lib/sublime/package_test.go
@@ -8,23 +8,30 @@ import (
 	"path"
 	"testing"
 
-	"github.com/limetext/lime-backend/lib"
 	_ "github.com/limetext/lime-backend/lib/commands"
 	"github.com/limetext/lime-backend/lib/packages"
 )
 
 func TestLoadPlugin(t *testing.T) {
+	pn := path.Join("testdata", "packages", "plugin.py")
+	pkg := newPKG(path.Join("testdata", "packages")).(*pkg)
+	pkg.loadPlugin(pn)
 
+	if _, exist := pkg.plugins[pn]; !exist {
+		t.Errorf("Expected to %s exist in %s package plugins", pn, pkg.Name())
+	}
 }
 
 func TestLoadPlugins(t *testing.T) {
+	pn := path.Join("testdata", "packages", "plugin.py")
+	pkg := newPKG(path.Join("testdata", "packages")).(*pkg)
+	pkg.loadPlugins()
 
+	if _, exist := pkg.plugins[pn]; !exist {
+		t.Errorf("Expected to %s exist in %s package plugins", pn, pkg.Name())
+	}
 }
 
-func TestLoadKeyBindings(t *testing.T) {
-
-}
-
-func TestLoadSettings(t *testing.T) {
-
+func init() {
+	packages.Unregister(packageRecord)
 }
diff --git a/lib/sublime/sublime_api_generated.go b/lib/sublime/sublime_api_generated.go
@@ -148,9 +148,7 @@ func sublime_PackagesPath(tu *py.Tuple) (py.Object, error) {
 	var (
 		arg1 string
 	)
-	if tu.Not() {
-		arg1 = "default"
-	} else if v, err := tu.GetItem(0); err != nil {
+	if v, err := tu.GetItem(0); err != nil {
 		return nil, err
 	} else {
 		if v3, err2 := fromPython(v); err2 != nil {

diff --git a/lib/sublime/testdata/packages/plugin.py b/lib/sublime/testdata/packages/plugin.py