replace_all

[zoli]

No description provided.

[ghost]

Hey, I am trying to fix this issue as an icebreaker into this project and learning Go. The issue I am facing is with using nextSelection (in lib/commands/findreplace.go) as a means to replace all words. If I use it, I have to return err every time as I always reach a point where there will be no more words to replace. Is it a better idea to create a helper function to return all regions to replace, or is returning an err everytime acceptable?

[zoli]

As you should call the nextSelection function multiple times you can check if there was error in all calls or not. If a single call didn't return error you shouldn't return error.

[quarnster]

Is it a better idea to create a helper function to return all regions to replace,

Such a function will be needed sometime for the "highlight matches" setting, so it isn't a bad idea to think about how to implement it.

[erbridge]

Migrated to limetext/backend#2.