Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versioning strategy #66

Open
cfv1000 opened this issue Apr 30, 2024 · 1 comment
Open

versioning strategy #66

cfv1000 opened this issue Apr 30, 2024 · 1 comment

Comments

@cfv1000
Copy link

cfv1000 commented Apr 30, 2024

From: https://semver.org/

MAJOR version when you make incompatible API changes
MINOR version when you add functionality in a backward compatible manner
PATCH version when you make backward compatible bug fixes

  1. v0.6.8...v0.6.9
    This version has not fixed any bug
    Expected: minor version
    Actual: fix version

  2. v0.6.4...v0.6.5
    This version has introduced a new feature.
    The feature uses PHP8 specific syntax

Expected - composer json updates the minimum php required version
Expected - minor version bump
Expected - phpunit tests catch this kind of backwards incompatible changes.

Actual: patch bump
Actual: tests pass
Actual: composer json mentions support for php7 (which is false)

Based on these notes, I would conclude that this library might be unreliable to use in projects where SEMVER versioning is used as a best practice.

@arietimmerman
Copy link
Collaborator

Probably you are right. I could consider following are more structured versioning approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants