Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to parse valid manifest file due to incorrect regular expression #5

Closed
shaon002 opened this issue Oct 9, 2018 · 1 comment
Closed
Assignees

Comments

@shaon002
Copy link

shaon002 commented Oct 9, 2018

Steps to reproduce:

  • parse a valid jdbc driver jar file.
  • the manifest.mf file contains entries as bellow:
    SHA-256-Digest: i68JQ1kocrRMFY73CPfLbGDIDnLKYDutWCyV2OVPs1M=

Seems that the problem is in the regular expression in Jar.js file:
// Extract the name and value from entry line
var pair = line.match(/^([a-z_-]+): (.*)$/i)

The expression could be more generic to extract pair.

@limulus limulus self-assigned this Oct 10, 2018
@limulus
Copy link
Owner

limulus commented Oct 20, 2018

Thanks for this, @shaon002! I’ve just published v2.0.0 which should contain a fix. The reason for the major version bump was only because I dropped support for Node.js 0.12 (although it will likely continue to work for some time in 0.12).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants