Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to rebind going back instead of using strumbar for going back. #115

Closed
yaladre opened this issue Dec 17, 2021 · 2 comments · Fixed by #136
Closed

Add function to rebind going back instead of using strumbar for going back. #115

yaladre opened this issue Dec 17, 2021 · 2 comments · Fixed by #136
Assignees

Comments

@yaladre
Copy link

yaladre commented Dec 17, 2021

Similar to what AL has, just the option to bind a specific button to go back instead of having it always binded to the strumbar.

@fisyher
Copy link
Collaborator

fisyher commented Dec 19, 2021

Cancel button should always be fixed to at least the Esc Key to avoid potential loss of control issue. I will remove the fixed binding of Cancel to the Pick button as it does not make sense.

As for adding Key configuration function for Enter and Cancel function, I will not implement them unless there is a good reason to do so. Just use Enter and Esc keys for now.

@fisyher
Copy link
Collaborator

fisyher commented Dec 25, 2021

After looking into this deeper, I realized the Pick key is functioning as a built-in Back Command similar to Drum LC which is not the same as the Cancel function in Esc key.

It is a convenience feature so that player can move out of a directory without the need to scroll all the way to the Back Box and without touching the keyboard. As such, I will not remove this fixed binding for now.

@yaladre: Would you like to elaborate on your issue with using Pick as the Back command?

@fisyher fisyher self-assigned this Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants