Issues with Skill Points for Guitar/bass

[ericpignet]

Two issues reported on Discord, for guitar & drums.

1. Skill points not updated in game screen and in result screen. Stay 0.00
This one can be fixed easily. It happens only if Drums is set as all-auto: in this case Skill point is currently fixed to 0.00.
I plan set Skill points to 0.00 only if we are in Drums mode and Drums is all-auto.

2. Wrong rank in the history panel in Song selection
This one is more tricky.
The problem is that we calculate an Overall ranking which takes both Guitar and Bass into account. The formula is:

(perfectGuitar+perfectBass)/(NbNonAutoChipsGuitar+NbNonAutoChipsBass)*100*0.85+(GreatGuitar+greatBass)/(NbNonAutoChipsGuitar+NbNonAutoChipsBass)*100*0.35+
(maxComboGuitar+maxComboBass)/(NbNonAutoChipsGuitar+NbNonAutoChipsBass)*100*0.15

If you play only guitar and put bass on all-auto, the bassComboBass will be full, which artificially improves the overall ranking.
This overall ranking is also used to select the background image in the result screen.

What I'm planning to do for the song selection is:

• if guitar and bass are played together keep the Overall ranking
• if only guitar or bass is played, use the normal ranking for single instrument
• add instrument in the history panel (e.g. Guitar/Bass/G+B )