Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Latest release] I can not fold/unfold attachments #448

Open
chibenwa opened this issue May 7, 2021 · 5 comments
Open

[Latest release] I can not fold/unfold attachments #448

chibenwa opened this issue May 7, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@chibenwa
Copy link
Member

chibenwa commented May 7, 2021

attachment-card-2021-05-07_10.07.13.mp4

I click the fold/unflod side panel button without effect.

Mozilla Firefox 88.0

@chibenwa chibenwa added the bug Something isn't working label May 7, 2021
@Arsnael
Copy link
Member

Arsnael commented May 10, 2021

Hm I guess it's more about the definition of what we want here. I just checked with a mail where I have 4 or 5 attachments (so multi lines display as too many attachments to appear on one line.

When I play with the fold/unfold button, it switches between a reduced view of it with a scroll panel, or a full view of all attachments. I don't think I would see it as a bug, but more like maybe need to rethink this function

@chibenwa
Copy link
Member Author

Then we should not show the button when attachments fits in one line

@Arsnael
Copy link
Member

Arsnael commented May 10, 2021

Or maybe fold should be well a real fold that just does not show attachments, and you need to unfold to display them?

@fabienmoyon
Copy link
Member

yes exactly but it's not so easy to know if attachments fits in one line or not because it depend of the size of your desktop. In one line you can have 1,2,3 or 4 attachments with the responsive design).
I will try later to fix by hide the collapse/expend icon if not needed

@fabienmoyon
Copy link
Member

related to #347 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants