Skip to content

Latest commit

 

History

History
108 lines (74 loc) · 4.45 KB

CONTRIBUTING.md

File metadata and controls

108 lines (74 loc) · 4.45 KB
Raw

How to contribute to JMAP-DRAFT-CLIENT ?

If you read this page, you're probably interested in contributing to the jmap-draft-client library. That's awesome !

Contributing code

jmap-draft-client tries to respect state of the art javascript coding guidelines. Here are some tips to get started

getting started

We use GitHub fork/pull request workflow to allow everyone to send patches to the project.

Once you cloned the repository, use npm to install the dependencies:

npm install

You can then transpile the library and run the tests by using grunt:

grunt

If you don't have grunt installed, use the following command:

npm install -g grunt-cli

philosophy

jmap-draft-client has been built around two well known patterns: promises, and fluent interface.

Promise is a pattern to deal with asynchronous code. Instead of using callbacks, you return an object that represent the result of your async call, be it successful or not. It's so widely used that it has been included in the EcmaScript 2015 specification, which is the specification of the JavaScript language itself. The jmap-draft-client library uses the promise implementation of your choice, we already provide the EcmaScript 2015 Promise provider and the Q provider.

Fluent interface is a nice way of writing code: you can chain calls to different class methods. An example is worth a thousand words:

new jmap.Client(<your Transport>, <your PromiseProvider>)
    .withAPIUrl('https://jmap.my.server.com')
    .withAuthenticationToken('YourAuthenticationToken')
    .getMailboxes()
    .then((mailboxes) => {
        // Do something with the list of mailboxes
    }, (err) => {
        // An error occured
    });

Code formating and check

The jmap-draft-client use the AirBNB JavaScript style convention, with some relaxed rules:

  • we do not require new lines after block
  • we do not require a trailing comma at the end of arrays & objects
  • we allow declaration of multiple variables in a single "var" statement
  • we do not require a new line before a line comment
  • we do not enforce a special case for object properties

All those settings can be found in the code style checker configuration file.

. We use jshint static code analyser, and jscs code style checker.

At any moment, you can see if your code validates by running

grunt linters

documentation

The jmap-draft-client project uses jsdoc version 3 and up. When you change code, please make sure to write or modify the related documentation, and make sure that the documentation displays nicely. We need a 100% coverage on public API documentation. At any moment, you can run

grunt apidoc

to generate the documentation. Please note that the documentation is not commited in the repository.

tests

Tests are a super-important thing for the project developers. If you ever contribute code to the jmap-draft-client library, please make sure you also provide the associated tests, with 100% coverage on your code. Tests is what ensure that the library will rock on the long run, and that many developers can work together on the same codebase.

Thanks to the wonderfull abilities of the node.js ecosystem, we are able to have the same tests for the backend (read: node.js) and the frontend (browsers). You'll find all the tests in the test/common folder. Tests specific to the frontend are located in test/frontend, and backend specifics... you guessed it.

You can run tests at any moment in your development process by using the grunt command:

grunt

Fill the change log

The last step!

Please before to open your pull-request, write in the CHANGELOG.md file a line explaining briefly your changes under the 'master' section.

## [master]
### Added
- What I did #GITHUB_ISSUE