Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apisix plugin - support case Redis down #1023

Closed
vttranlina opened this issue Apr 29, 2024 · 1 comment · Fixed by #1025
Closed

Apisix plugin - support case Redis down #1023

vttranlina opened this issue Apr 29, 2024 · 1 comment · Fixed by #1025
Assignees

Comments

@vttranlina
Copy link
Member

Context

In the tmail-apisix-plugin-runner plugin, we currently have a TokenRevokedFilter. This filter is responsible for checking whether the token in the request has been revoked previously by querying Redis.
The issue arises when Redis is down, causing the checking process to take a significant amount of time and resulting in the inability to perform login and logout flows.

Ref: #1013

How to resolve it

  • Add a parameter ignoreRedisErrors (defaulting to false), it can be configurable. If turned to true, if redis fails we ignore the logout flow, effectively preserving the service at a cost of a bit of security.

DOD

  • Add test case at com.linagora.apisix.plugin.RedisRevokedTokenRepositoryTest
  • Document
@vttranlina
Copy link
Member Author

pr #1025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant