-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JMAP spec about attachment thumbnails #593
Comments
Question: I saw initially a size was proposed as query param (small|medium|large). I took it out as the size is done when we generate and store the thumbnail with the listener. I don't think we want to store it 3 times either on the different sizes. So to me that query param is unecessary? WDYT? |
Maybe we need to experiment with linThumbnail to understand exact dimensions of small, medium, large. If we choose one of them that fits all the cases then I am OK to discard the others. |
IMO different sizes could help the client side have choices to load/render the thumbnail depending on network connection condition/device resolution. E.g:
Think about Youtube video resolution. |
My lab:
Conclusion
|
The LARGE size seems not good to me. Its size is even bigger than the original attachment :p |
@vttranlina you tried the linshare thumbnail server locally? Nice :) LARGE is definitely way too big and not usable in our case. I feel MEDIUM is too big too honestly (but might be wrong). I think SMALL size is likely enough? |
Is there ways to get linthumbnail generate only small size? |
customize the linthumbnail image |
Open an issue there to see if we can add a query parameter. |
created: linagora/linshare-thumbnail-server#8 |
Write a custom tmail attachment thumbnails spec allowing users to fetch thumbnails of their mail attachments
A user should be able to see small preview of his attachments (thumbnails) when reading his emails without necessary having to fully download it
This would be implemented as a new JMAP download api route that would return the thumbnail :
Alongside a new capability extension defined as
com:linagora:params:jmap:thumbnails
The route would return 404 if no thumbnail is found.
We need to advertise this in the jmap session as well
DoD : spec written
The text was updated successfully, but these errors were encountered: