Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove band_to_calc from analysis functions? #338

Open
hombit opened this issue Dec 22, 2023 · 1 comment
Open

Remove band_to_calc from analysis functions? #338

hombit opened this issue Dec 22, 2023 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@hombit
Copy link
Contributor

hombit commented Dec 22, 2023

After by_band was implemented in #327, the band_to_calc argument in the analysis function looks redundant. Currently, a user can achieve the same behavior for a few bands with source filtering, and for each band with by_band. In fact, I believe it is worth having the ability to ignore the passband sometimes in order to apply certain types of analysis over all object's sources, as discussed in #325 and #323.

Here, I propose removing band_to_calc from analysis functions and not requiring the band column for them.

@nevencaplar nevencaplar added the enhancement New feature or request label Dec 26, 2023
@hombit hombit added the question Further information is requested label Dec 28, 2023
@hombit
Copy link
Contributor Author

hombit commented Jan 3, 2024

Additional suggestion: we can change batch(by_band: bool) to batch(by_band: bool | BandType | list[BandType]), where BandType is a column dtype for bands, typically str or int. So by_band would also filter bands to have a single band only, batch(by_band='g') or multiple, but not all, bands, batch(by_band=['g', 'r'])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants