Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question for user dictionary parsing when using non-compressed local dictionary #196

Closed
ypenglyn opened this issue Jun 29, 2022 · 5 comments · Fixed by #198
Closed

Question for user dictionary parsing when using non-compressed local dictionary #196

ypenglyn opened this issue Jun 29, 2022 · 5 comments · Fixed by #198
Assignees
Labels
bug Something isn't working

Comments

@ypenglyn
Copy link

While keep using non-compressed local dictionary along with user dictionary, the build_user_dict is failed with error user dictionary path is not set.. I think the related code is here and want to confirm if it is ok to fallback the user dictionary parsing to use IpadicBuilder while using local dictionary?

@ypenglyn
Copy link
Author

@mosuka
Do you have any thoughts on this?

@mosuka
Copy link
Member

mosuka commented Jun 29, 2022

Hi @ypenglyn ,
Thanks for your report.
Could you share how to reproduce the errors you are facing?

@mosuka
Copy link
Member

mosuka commented Jun 29, 2022

@ypenglyn
I understand your point.
It seems to be a bug. It does not work correctly if you specify a dictionary in a local directory.
I will fix it.
Thanks!

@mosuka mosuka self-assigned this Jun 29, 2022
@mosuka mosuka added the bug Something isn't working label Jun 29, 2022
@ypenglyn
Copy link
Author

ypenglyn commented Jun 29, 2022

@mosuka

I tried to fix this with some local changes, if it is ok I will create a pull-request for this.

@mosuka
Copy link
Member

mosuka commented Jun 30, 2022

@ypenglyn
Thank you.
But I am just refactoring the CLI so I will also fix it.
Thanks. :)

@mosuka mosuka mentioned this issue Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants