Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing references #35

Closed
rasbt opened this issue May 19, 2022 · 4 comments
Closed

Add missing references #35

rasbt opened this issue May 19, 2022 · 4 comments

Comments

@rasbt
Copy link

rasbt commented May 19, 2022

Hey,

almost there. Just a few final things to check off for the review! There is the item

References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?

I just see that the paper's Reference section is blank. Could you fill it in with the required details?

@lindseysbrown
Copy link
Owner

Hi @rasbt , I think that's how the journal's paper building system is set up. (If you check the repos for recently published papers, the References section shows blank for all of them in github.) References are listed in paper.bib. I just rechecked doi's - not finding one for Greiwank 1989 but I have been able to track them down for the other citations.

@rasbt
Copy link
Author

rasbt commented May 20, 2022

Sounds good! Could you add the correct citation for the Andreas Griewank entry though please:

@article{griewank1989automatic,
  title={On automatic differentiation},
  author={Griewank, Andreas},
  journal={Mathematical Programming: recent developments and applications},
  volume={6},
  number={6},
  pages={83--107},
  year={1989},
  publisher={Amsterdam}
}

this doesn't look right to me. I think it's a book, and the publisher is Kluwer. So, this article would be a book chapter part of the book.

@lindseysbrown
Copy link
Owner

Sorry. It's been updated now.

@rasbt
Copy link
Author

rasbt commented May 20, 2022

Looks good to me!

@rasbt rasbt closed this as completed May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants