New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unclutter breaks Chrome's PDF viewer #1
Comments
Thank you for raising the issue! I just added the "ends with .pdf" check in ed84ee2. Do you have an example of a site with an embedded pdf viewer? As an immediate workaround, does the pdf viewer work after excluding the domain with the switch in the top right, then reloading the page? |
@marcocipriani01 The fix for Please let me know if the extension still breaks for embedded pdf viewers. |
Thank you, unfortunately the issue is still present in the latest release (I think it's 0.5.6, right?). If I enable "automatically unclutter articles" and open an online PDF, I still get a blank page. Toggling the switch and reloading the page works as a temporary workaround. Here's an example of a PDF viewer embedded in a page. Unclutter seems work as intended in this case. |
Ahh, you are right. I must have mixed up the versions. I just released 0.6.0 which definitely fixes this issue and also includes other improvements to the article detection (see article-detection.md). Hopefully it's approved by tomorrow morning in the store. Thanks for the link on the pdf embed. I agree that it looks reasonable enough, let's leave it like that for now. |
OK, I'll let you know tomorrow if the issue is fixed! |
I can confirm that v0.6.0 fixes the bug. However, if I manually click on the Unclutter icon, the PDF page gets uncluttered, and therefore becomes blank like before. I'm nitpicking here, but an error message would be nice for new users (something like "Unclutter doesn't work on PDFs"). Anyway, I think that the latest release is much more polished, and even manages to clean pages WAY better than Chrome's Reader Mode. Wikipedia becomes a ugly mess with Reader Mode, while Unclutter makes a damn good job. Keep up the good work! |
Thank you for the nice feedback! ❤️ With fc93626 the extension now refuses to activate on Thank you again for reporting this! Please let me know of other issues that you find. There's now a "Report bug" icon within the extension itself that hopefully makes creating an issue here easier. |
Description
When trying to view an online PDF in Chrome, Unclutter displays an error message ("page broken") and the PDF doesn't load. If I toggle the unclutter switch on the top right, the PDF remains hidden under an empty page or is just barely visible on the top (just a few pixels of the PDF can be seen).
A solution
Do not unclutter any page that ends with
.pdf
or contains Chrome's PDF viewer (note: some pages embed the viewer, so that has to be taken into account too).Example websites
Literally any online PDF
Tested on
Chrome OS with Chrome 99
The text was updated successfully, but these errors were encountered: