Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure server max request length of 0 or Long.MAX_VALUE doesn't ca… #1549

Merged
merged 3 commits into from Jan 24, 2019

Conversation

anuraaga
Copy link
Collaborator

…use incorrect gRPC max message size.

Wish I did this ages ago when first running into it...

@trustin trustin added the defect label Jan 23, 2019
@trustin trustin added this to the 0.80.0 milestone Jan 23, 2019
Copy link
Collaborator

@trustin trustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@hyangtack hyangtack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #1549 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1549      +/-   ##
============================================
+ Coverage     72.65%   72.66%   +0.01%     
- Complexity     7252     7256       +4     
============================================
  Files           677      677              
  Lines         29326    29326              
  Branches       3578     3579       +1     
============================================
+ Hits          21307    21311       +4     
+ Misses         6167     6166       -1     
+ Partials       1852     1849       -3
Impacted Files Coverage Δ Complexity Δ
.../armeria/internal/grpc/ArmeriaMessageDeframer.java 69.33% <100%> (+0.94%) 44 <0> (+2) ⬆️
.../com/linecorp/armeria/server/grpc/GrpcService.java 94.93% <100%> (ø) 22 <0> (ø) ⬇️
...om/linecorp/armeria/client/HttpSessionHandler.java 59.48% <0%> (-1.73%) 28% <0%> (-1%)
...p/armeria/common/stream/DeferredStreamMessage.java 82.2% <0%> (-1.7%) 31% <0%> (-1%)
...armeria/client/HttpClientPipelineConfigurator.java 70.7% <0%> (+0.33%) 37% <0%> (+1%) ⬆️
...rp/armeria/common/stream/DefaultStreamMessage.java 91.42% <0%> (+1.42%) 54% <0%> (+1%) ⬆️
...corp/armeria/common/stream/FixedStreamMessage.java 91.07% <0%> (+1.78%) 23% <0%> (+1%) ⬆️
...meria/internal/AbstractHttp2ConnectionHandler.java 90% <0%> (+6.66%) 12% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e02b9ea...4499932. Read the comment docs.

Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trustin trustin merged commit 3ee3eac into line:master Jan 24, 2019
fmguerreiro pushed a commit to fmguerreiro/armeria that referenced this pull request Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants