Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only initialize json marshaller when needed. #1558

Merged
merged 1 commit into from Jan 28, 2019

Conversation

anuraaga
Copy link
Collaborator

Bytecode generation can take a while during initialization and is pointless if it won't be needed. Client already had this check.

Fixes #1556

@codecov
Copy link

codecov bot commented Jan 27, 2019

Codecov Report

Merging #1558 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1558      +/-   ##
============================================
- Coverage     72.76%   72.71%   -0.06%     
- Complexity     7281     7282       +1     
============================================
  Files           679      679              
  Lines         29379    29381       +2     
  Branches       3591     3591              
============================================
- Hits          21379    21364      -15     
- Misses         6138     6160      +22     
+ Partials       1862     1857       -5
Impacted Files Coverage Δ Complexity Δ
...inecorp/armeria/server/grpc/ArmeriaServerCall.java 83.2% <ø> (ø) 76 <0> (ø) ⬇️
.../com/linecorp/armeria/server/grpc/GrpcService.java 95.06% <100%> (+0.12%) 23 <2> (+1) ⬆️
.../linecorp/armeria/internal/Http1ObjectEncoder.java 62.92% <0%> (-11.22%) 43% <0%> (-5%)
...meria/internal/AbstractHttp2ConnectionHandler.java 83.33% <0%> (-6.67%) 11% <0%> (-1%)
...com/linecorp/armeria/internal/grpc/GrpcStatus.java 58.06% <0%> (-3.23%) 21% <0%> (-1%)
.../com/linecorp/armeria/server/docs/ServiceInfo.java 72.72% <0%> (-2.28%) 16% <0%> (-1%)
...common/stream/AbstractStreamMessageDuplicator.java 76.29% <0%> (-0.5%) 9% <0%> (ø)
...corp/armeria/common/logging/DefaultRequestLog.java 81.03% <0%> (+0.46%) 139% <0%> (+1%) ⬆️
.../armeria/internal/grpc/ArmeriaMessageDeframer.java 69.33% <0%> (+0.94%) 44% <0%> (+1%) ⬆️
.../linecorp/armeria/client/Http1ResponseDecoder.java 60% <0%> (+1.81%) 23% <0%> (+1%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 104f0b4...6120580. Read the comment docs.

Copy link
Collaborator

@trustin trustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anuraaga!

@trustin trustin added the defect label Jan 28, 2019
@trustin trustin added this to the 0.80.0 milestone Jan 28, 2019
Copy link
Contributor

@hyangtack hyangtack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@trustin trustin merged commit 0a65ae4 into line:master Jan 28, 2019
fmguerreiro pushed a commit to fmguerreiro/armeria that referenced this pull request Sep 19, 2020
Bytecode generation can take a while during initialization and is pointless if it won't be needed. Client already had this check.

Fixes line#1556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants