Add more shortcut methods for convenience #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trustin
force-pushed
the
more_shortcuts
branch
from
7e8cc0f
to
d1bd0f7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1576 +/- ##
=========================================
Coverage ? 72.71%
Complexity ? 7509
=========================================
Files ? 695
Lines ? 30230
Branches ? 3689
=========================================
Hits ? 21982
Misses ? 6349
Partials ? 1899
Continue to review full report at Codecov.
|
minwoox
approved these changes
Feb 11, 2019
Motivation: Skimmed through our test cases and thought a few shortcut methods would be useful to reduce some tedious repetition. Modifications: - Added `contentType()` to: - `HttpRequest` - `AggregatedHttpMessage` - Added `contentUtf8()`, `contentAscii()` and `content(Charset)` to `AggregatedHttpMessage`. - Accepted `CharSequence` as well as String in: - `HttpRequest.of()` - `HttpRespons.of()` - `AggregatedHttpMessage.of()` - Replaced the old usage with the new concise usage. Result: Brevity.
trustin
force-pushed
the
more_shortcuts
branch
from
d1bd0f7
to
1cf66ad
Compare
|
Thanks, @minwoox ! |
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this pull request
Sep 19, 2020
Motivation: Skimmed through our test cases and thought a few shortcut methods would be useful to reduce some tedious repetition. Modifications: - Added `contentType()` to: - `HttpRequest` - `AggregatedHttpMessage` - Added `contentUtf8()`, `contentAscii()` and `content(Charset)` to `AggregatedHttpMessage`. - Accepted `CharSequence` as well as String in: - `HttpRequest.of()` - `HttpRespons.of()` - `AggregatedHttpMessage.of()` - Replaced the old usage with the new concise usage. Result: Brevity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Skimmed through our test cases and thought a few shortcut methods would
be useful to reduce some tedious repetition.
Modifications:
contentType()to:HttpRequestAggregatedHttpMessagecontentUtf8(),contentAscii()andcontent(Charset)toAggregatedHttpMessage.CharSequenceas well as String in:HttpRequest.of()HttpRespons.of()AggregatedHttpMessage.of()Result:
Brevity.