New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add verboseSocketExceptions
flag
#1577
Conversation
Motivation: Since we fixed the behavior of `verboseExceptions` flag with respect to `Exceptions.isExpected()`, we received the report of increased exceptions logged. However, most of them were harmless socket-related ones such as `connection reset by peer`, where we do not have control over, because network disconnection can always happen. Modifications: - Added a new flag `verboseSocketException` which defaults to `false`. - Modified `Exceptions.isExpected()` to use `verboseSocketException` instead of `verboseException`. Result: - Less noisy log messages
a27a6a6
to
0a3d3c7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1577 +/- ##
============================================
+ Coverage 72.77% 72.85% +0.08%
- Complexity 7495 7518 +23
============================================
Files 695 695
Lines 30171 30190 +19
Branches 3683 3687 +4
============================================
+ Hits 21956 21994 +38
+ Misses 6310 6298 -12
+ Partials 1905 1898 -7
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1577 +/- ##
============================================
+ Coverage 72.77% 72.85% +0.08%
- Complexity 7495 7518 +23
============================================
Files 695 695
Lines 30171 30190 +19
Branches 3683 3687 +4
============================================
+ Hits 21956 21994 +38
+ Misses 6310 6298 -12
+ Partials 1905 1898 -7
Continue to review full report at Codecov.
|
Motivation: Since we fixed the behavior of `verboseExceptions` flag with respect to `Exceptions.isExpected()`, we received the report of increased exceptions logged. However, most of them were harmless socket-related ones such as `connection reset by peer`, where we do not have control over, because network disconnection can always happen. Modifications: - Added a new flag `verboseSocketException` which defaults to `false`. - Modified `Exceptions.isExpected()` to use `verboseSocketException` instead of `verboseException`. Result: - Less noisy log messages
Motivation:
Since we fixed the behavior of
verboseExceptions
flag with respect toExceptions.isExpected()
, we received the report of increasedexceptions logged. However, most of them were harmless socket-related
ones such as
connection reset by peer
, where we do not have controlover, because network disconnection can always happen.
Modifications:
verboseSocketException
which defaults tofalse
.Exceptions.isExpected()
to useverboseSocketException
instead of
verboseException
.Result: