Add metrics related to timeout #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: It would be nice if we provide timeout metrics by default. Modifications: - Add `requestTimeout` metric in server-side - Add `responseTimeout` and `writeTimeout` metrics in client-side - Add `ServiceRequestContext.isRequestTimedOut()` - Deprecate `RequestContext.isTimedOut()` Result: - More metrics - Close line#1580
trustin
requested changes
Feb 13, 2019
core/src/main/java/com/linecorp/armeria/common/AbstractRequestContext.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/internal/metric/RequestMetricSupport.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/internal/metric/RequestMetricSupport.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/server/DefaultServiceRequestContext.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/server/DefaultServiceRequestContext.java
Outdated
Show resolved
Hide resolved
minwoox
force-pushed
the
add_timeout_metrics
branch
from
2b0bf74
to
2e387f7
Compare
minwoox
force-pushed
the
add_timeout_metrics
branch
from
2e387f7
to
94e54b5
Compare
Codecov Report
@@ Coverage Diff @@
## master #1589 +/- ##
============================================
- Coverage 72.83% 72.83% -0.01%
- Complexity 7544 7548 +4
============================================
Files 697 697
Lines 30324 30353 +29
Branches 3701 3704 +3
============================================
+ Hits 22087 22108 +21
- Misses 6330 6343 +13
+ Partials 1907 1902 -5
Continue to review full report at Codecov.
|
trustin
approved these changes
Feb 14, 2019
|
Thanks, @minwoox ! |
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this pull request
Sep 19, 2020
Motivation:
It would be nice if we provide request timeout metrics by default.
Modifications:
- Add counters
- `timeouts{cause=RequestTimeoutException}` (server-side)
- `timeouts{cause=WriteTimeoutException}` (client-side)
- `timeouts{cause=ResponseTimeoutException}` (client-side)
- Add `ServiceRequestContext.isTimedOut()`
- Deprecate `RequestContext.isTimedOut()`
Result:
- More metrics
- Close line#1580
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It would be nice if we provide request timeout metrics by default.
Modifications:
timeouts{cause=RequestTimeoutException}(server-side)timeouts{cause=WriteTimeoutException}(client-side)timeouts{cause=ResponseTimeoutException}(client-side)ServiceRequestContext.isTimedOut()RequestContext.isTimedOut()Result: