Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoutingTrie can now handle a trailing slash correctly #1741

Merged
merged 1 commit into from Apr 26, 2019

Conversation

hyangtack
Copy link
Contributor

@hyangtack hyangtack commented Apr 25, 2019

Motivation:

Modifications:

  • Made RoutingTrie handle the trailing slash correctly.

Result:

  • A service can be correctly mapped to the path with a trailing slash.

@hyangtack hyangtack added this to the 0.85.0 milestone Apr 25, 2019
@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #1741 into master will increase coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1741      +/-   ##
============================================
+ Coverage     72.93%   72.94%   +<.01%     
  Complexity     8153     8153              
============================================
  Files           736      736              
  Lines         32465    32468       +3     
  Branches       3989     3991       +2     
============================================
+ Hits          23678    23683       +5     
+ Misses         6757     6756       -1     
+ Partials       2030     2029       -1
Impacted Files Coverage Δ Complexity Δ
.../java/com/linecorp/armeria/server/RoutingTrie.java 93.65% <75%> (+0.1%) 22 <0> (+1) ⬆️
...com/linecorp/armeria/internal/grpc/GrpcStatus.java 64.7% <0%> (-2.95%) 24% <0%> (-1%)
...om/linecorp/armeria/client/HttpSessionHandler.java 59.48% <0%> (-1.73%) 28% <0%> (-1%)
...com/linecorp/armeria/server/HttpServerHandler.java 79.35% <0%> (-0.65%) 79% <0%> (-1%)
...common/stream/AbstractStreamMessageDuplicator.java 74.16% <0%> (+0.47%) 9% <0%> (ø) ⬇️
...a/common/grpc/protocol/ArmeriaMessageDeframer.java 72.24% <0%> (+0.47%) 49% <0%> (+1%) ⬆️
...rp/armeria/common/stream/DefaultStreamMessage.java 90.71% <0%> (+1.42%) 54% <0%> (+1%) ⬆️
.../main/java/com/linecorp/armeria/server/Server.java 81.28% <0%> (+1.47%) 16% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35cb85f...41448a9. Read the comment docs.

Motivation:
- line#1735 made `DefaultPathMapping` generate a correct path pattern with a trailing slash,
  but the `RoutingTrie` hasn't still handled the trailing slash correctly.

Modifications:
- Made `RoutingTrie` handle the trailing slash correctly.

Result:
- A service can be correctly mapped to the path with a trailing slash.
@trustin
Copy link
Member

trustin commented Apr 26, 2019

👍

@trustin trustin merged commit 318fd00 into line:master Apr 26, 2019
fmguerreiro pushed a commit to fmguerreiro/armeria that referenced this pull request Sep 19, 2020
Motivation:
- line#1735 made `DefaultPathMapping` generate a correct path pattern with a trailing slash,
  but the `RoutingTrie` hasn't still handled the trailing slash correctly.

Modifications:
- Made `RoutingTrie` handle the trailing slash correctly.

Result:
- A service can be correctly mapped to the path with a trailing slash.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants