Make sure boss EventLoopGroups are terminated on startup fail…
#2288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related: https://stackoverflow.com/q/58891320/55808 Motivation: When a server fails to start up, its boss `EventLoopGroup` is not terminated, leaving a dangling non-daemon thread which prevents a JVM process from terminating itself. Modifications: - Make sure the boss `EventLoopGroup`s are always terminated by keeping the boss groups created by `Server`. Result: - No more dangling non-daemon threads on server startup failure
anuraaga
reviewed
Dec 2, 2019
Codecov Report
@@ Coverage Diff @@
## master #2288 +/- ##
===========================================
- Coverage 73.71% 73.7% -0.01%
- Complexity 9897 9900 +3
===========================================
Files 871 871
Lines 37981 37982 +1
Branches 4655 4655
===========================================
Hits 27996 27996
+ Misses 7607 7606 -1
- Partials 2378 2380 +2
Continue to review full report at Codecov.
|
anuraaga
approved these changes
Dec 2, 2019
anuraaga
reviewed
Dec 2, 2019
Co-Authored-By: Anuraag Agrawal <anuraaga@gmail.com>
trustin
changed the title
EventLoopGroups are terminated on startup failureEventLoopGroups are terminated on startup fail…
|
Thanks for reviewing! |
|
Special thanks to @magnuschatt for reporting this issue via StackOverflow - https://stackoverflow.com/questions/58891320/how-to-make-armeria-exit-on-an-address-already-in-use-error |
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this pull request
Sep 19, 2020
…e#2288) Related: https://stackoverflow.com/q/58891320/55808 Motivation: When a server fails to start up, its boss `EventLoopGroup` is not terminated, leaving a dangling non-daemon thread which prevents a JVM process from terminating itself. Modifications: - Make sure the boss `EventLoopGroup`s are always terminated by keeping the boss groups created by `Server`. Result: - No more dangling non-daemon threads on server startup failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: https://stackoverflow.com/q/58891320/55808
Motivation:
When a server fails to start up, its boss
EventLoopGroupis notterminated, leaving a dangling non-daemon thread which prevents a JVM
process from terminating itself.
Modifications:
EventLoopGroups are always terminated by keepingthe boss groups created by
Server.Result: