Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where query params disappear when WebClient executes #2309

Conversation

ildartuykin
Copy link
Contributor

Bugfix- disappearing query params, during webclient request execution with undefined endpoint, right CLA commit email

@ikhoon ikhoon added the defect label Dec 10, 2019
@ikhoon ikhoon added this to the 0.98.0 milestone Dec 10, 2019
Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ildartuykin ! 👍

Copy link
Member

@trustin trustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @ildartuykin !

@codecov
Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #2309 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2309      +/-   ##
============================================
- Coverage     73.67%   73.65%   -0.03%     
+ Complexity    10168    10162       -6     
============================================
  Files           882      882              
  Lines         38863    38866       +3     
  Branches       4812     4813       +1     
============================================
- Hits          28632    28625       -7     
- Misses         7776     7787      +11     
+ Partials       2455     2454       -1
Impacted Files Coverage Δ Complexity Δ
.../com/linecorp/armeria/client/DefaultWebClient.java 73.8% <100%> (+2.01%) 13 <0> (+1) ⬆️
...com/linecorp/armeria/server/saml/SamlEndpoint.java 62.5% <0%> (-2.5%) 10% <0%> (-1%)
...a/com/linecorp/armeria/client/HttpChannelPool.java 72.76% <0%> (-2.34%) 59% <0%> (-2%)
...inecorp/armeria/server/HttpResponseSubscriber.java 83.96% <0%> (-1.69%) 72% <0%> (-5%)
.../main/java/com/linecorp/armeria/server/Server.java 82.93% <0%> (-1.2%) 28% <0%> (ø)
...armeria/server/healthcheck/HealthCheckService.java 83.51% <0%> (-1.1%) 47% <0%> (-1%)
...inecorp/armeria/server/grpc/ArmeriaServerCall.java 87.1% <0%> (-0.4%) 85% <0%> (-1%)
...p/armeria/common/stream/DeferredStreamMessage.java 87.69% <0%> (+1.53%) 39% <0%> (+1%) ⬆️
...client/endpoint/healthcheck/HttpHealthChecker.java 88.23% <0%> (+2.94%) 19% <0%> (+1%) ⬆️
...meria/common/stream/RegularFixedStreamMessage.java 87.75% <0%> (+6.12%) 14% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd19fd0...1af1fc3. Read the comment docs.

Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@trustin trustin changed the title Bugfix- disappearing query params, during webclient request execution… Fix a bug where query params disappear when WebClient executes a request Dec 11, 2019
@trustin trustin changed the title Fix a bug where query params disappear when WebClient executes a request Fix a bug where query params disappear when WebClient executes Dec 11, 2019
@trustin trustin merged commit e944125 into line:master Dec 11, 2019
@trustin
Copy link
Member

trustin commented Dec 11, 2019

Thanks again, @ildartuykin!

fmguerreiro pushed a commit to fmguerreiro/armeria that referenced this pull request Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants