Fail immediately on proxy connect exception #2805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhee17
force-pushed
the
bugfix/investigate-proxy-hang
branch
from
83dfb04
to
1c0af1f
Compare
jrhee17
changed the title
jrhee17
changed the title
minwoox
approved these changes
Jun 17, 2020
trustin
approved these changes
Jun 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #2805 +/- ##
============================================
- Coverage 72.80% 72.72% -0.08%
- Complexity 11929 11934 +5
============================================
Files 1049 1049
Lines 46467 46554 +87
Branches 5810 5810
============================================
+ Hits 33828 33856 +28
- Misses 9665 9724 +59
Partials 2974 2974 Continue to review full report at Codecov.
|
ikhoon
approved these changes
Jun 17, 2020
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this pull request
Sep 19, 2020
Motivation: Related: line#2801 Proxy client can hang when a connection is established, but the connection is closed without a `ProxyConnectEvent`. 1) If a `ProxyConnectEvent` is never received, we don't mark the session as complete. 2) Since the session isn't completed, the first write is never invoked 3) Previously we had been relying on `ProxyHandler`s pending write failures to be notified of proxy failure (`HttpRequestSubscriber.operationComplete` used to close the response previously). Modification: Try to fail the `sessionPromise` on proxy connect exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Related: #2801
Proxy client can hang when a connection is established, but the connection is closed without a
ProxyConnectEvent.ProxyConnectEventis never received, we don't mark the session as complete.ProxyHandlers pending write failures to be notified of proxy failure (HttpRequestSubscriber.operationCompleteused to close the response previously).Modification
Try to fail the
sessionPromiseon proxy connect exception