Fix not to raise an exception from `(Service|Client)RequestContext.cu… #2962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrentOrNull()` Motivation: `ServiceRequestContext.currentOrNull()` raises an `IllegalArgumentException` if the current ctx is `ClientRequestContext` and `ctx.root()` returns `null`. It's very confusing because all other APIs returns `null` if the name ends with `orNull`. So I think the API should return `null` instead of raising an exception. We could use `ClientRequestContext.roo()` to find out if the client call is invoked by a server request or not. Modification: - Returns `null` instread of raising an exception from `(Service|Client)RequestContext.currentOrNull()` Result: - `(Service|Client)RequestContext.currentOrNull()` does not throw an exception anymore.
Codecov Report
@@ Coverage Diff @@
## master #2962 +/- ##
============================================
- Coverage 73.24% 73.18% -0.06%
- Complexity 12211 12213 +2
============================================
Files 1062 1058 -4
Lines 47343 47380 +37
Branches 5979 5995 +16
============================================
Hits 34675 34675
- Misses 9636 9670 +34
- Partials 3032 3035 +3
Continue to review full report at Codecov.
|
ikhoon
approved these changes
Aug 3, 2020
trustin
reviewed
Aug 3, 2020
core/src/main/java/com/linecorp/armeria/client/ClientRequestContext.java
Outdated
Show resolved
Hide resolved
trustin
approved these changes
Aug 3, 2020
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this pull request
Sep 19, 2020
line#2962) * Fix not to raise an exception from `(Service|Client)RequestContext.currentOrNull()` Motivation: `ServiceRequestContext.currentOrNull()` raises an `IllegalArgumentException` if the current ctx is `ClientRequestContext` and `ctx.root()` returns `null`. It's very confusing because all other APIs returns `null` if the name ends with `orNull`. So I think the API should return `null` instead of raising an exception. We could use `ClientRequestContext.roo()` to find out if the client call is invoked by a server request or not. Modification: - Returns `null` instread of raising an exception from `(Service|Client)RequestContext.currentOrNull()` Result: - `(Service|Client)RequestContext.currentOrNull()` does not throw an exception anymore. * Address the comment by @trustin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rrentOrNull()`
Motivation:
ServiceRequestContext.currentOrNull()raises anIllegalArgumentExceptionif the current ctx is
ClientRequestContextandctx.root()returnsnull.It's very confusing because all other APIs returns
nullif the name ends withorNull.So I think the API should return
nullinstead of raising an exception.We could use
ClientRequestContext.roo()to find out if the client call is invoked by a server request or not.Modification:
nullinstread of raising an exception from(Service|Client)RequestContext.currentOrNull()Result:
(Service|Client)RequestContext.currentOrNull()does not throw an exception anymore.